zhangjun0x01 commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r566521593
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSource.java
##########
@@ -617,12 +617,14 @@ public void testFilterNotPushDownLike() {
explainNoPushDown = getTableEnv().explainSql(sqlNoPushDown);
Assert.assertFalse("Explain should not contain FilterPushDown",
explainNoPushDown.contains(expectedFilterPushDownExplain));
+
sqlNoPushDown = "SELECT * FROM " + TABLE_NAME + " WHERE data LIKE '%%' ";
resultLike = sql(sqlNoPushDown);
- Assert.assertEquals("Should have 2 records", 2, resultLike.size());
+ Assert.assertEquals("Should have 3 records", 3, resultLike.size());
Review comment:
I tested it again. In hive 2.3.7, the sql `select * from mytest where
data like '%' ` , data is null will not match. In flink 1.12, it will return
the value of data is null. I have not found the related flink jira for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
