richiebachala commented on PR #2376: URL: https://github.com/apache/iceberg-go/pull/2376#issuecomment-6718590920
@slachiewicz thanks, all four points are addressed in 435736c: - **Compressed register:** `registerTable` now goes through `table.NewFromLocation`, as the Glue and Hive register paths do, so gzip and zstd metadata files load. `TestRegisterCompressedMetadata` creates a table with `write.metadata.compression-codec=gzip` and registers the server's own `.gz.metadata.json`. It fails on c19f2bc and passes now. - **Nested namespaces:** `TestNestedNamespaces` covers creating under a missing parent (404), listing at the top level and by `parent`, listing a missing parent (404), refusing to drop a namespace that has children (409 `ErrNamespaceNotEmpty`), and dropping bottom-up. - **Staged create:** `TestStagedCreate` uses `catalog.WithStagedUpdates`. It checks that the create finishes with exactly one commit to the table and that the staged property is on the loaded table. A second staged create of the same name fails on `assert-create`, which surfaces as `ErrTableAlreadyExists`. - **`WithProperties`:** it now rejects `prefix` and `namespace-separator` in either defaults or overrides, and `NewHandler` panics with the key named. The doc comment points to `WithPrefix`. - **Purge:** keeping 204 is intentional. A purge request still drops the table from the catalog, so test code that drops with purge works unchanged. Only file deletion is out of scope. The `dropTable` comment now says this, and the package doc already notes that purge leaves files. Returning 501 would turn a successful drop into an error for callers that only care about the catalog entry. @laskoviymishka, I applied your `doc.go` suggestion as written. I've moved the roadmap to #2044 for tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
