pvary commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4513438060
##########
core/src/test/java/org/apache/iceberg/DeleteFileIndexTestBase.java:
##########
@@ -635,6 +640,78 @@ public void testEqualityDeleteDiscardMetrics() {
.containsExactly(Map.entry(fieldId, ByteBuffer.wrap(new byte[20])));
}
+ @TestTemplate
+ public void testEqualityDeleteNotPrunedByNonKeyColumnStats() {
+ // v4 tables can still inherit an equality delete written before an
upgrade to v4
+ int createFormatVersion = Math.min(formatVersion, 3);
+
+ Schema schema =
+ new Schema(
+ required(1, "id", Types.IntegerType.get()),
+ required(2, "data", Types.StringType.get()),
+ optional(3, "extra", Types.IntegerType.get()));
+ PartitionSpec spec =
PartitionSpec.builderFor(schema).withSpecId(0).build();
Review Comment:
Maybe:
```suggestion
PartitionSpec spec = PartitionSpec.unpartitioned();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
