adutra commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4515304259


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1410,34 @@ paths:
       - $ref: '#/components/parameters/prefix'
       - $ref: '#/components/parameters/namespace'
       - $ref: '#/components/parameters/table'
+      - $ref: '#/components/parameters/data-access'
 
     post:
       tags:
         - Catalog API
       summary: Remotely signs requests to object storage
       operationId: signRequest
+      description: >

Review Comment:
   Since we are reusing the same endpoint to sign and pre-sign, I think it 
could be good to clarify what is the expected input URL scheme for each 
delegation mode.
   
   With `remote-signing` the expectation is that the incoming URL is an HTTP(S) 
URL, as computed by the client SDK from a virtual storage location. IOW, we 
expect `https://bucket.s3.us-east-1.amazonaws.com/key` and not 
`s3://bucket/key`. This is why we have `uri` and also `method`.
   
   But I'm seeing evidence that we might be designing `remote-presigning` to 
work with S3 input URLs instead: [a separate signer client was 
proposed](https://github.com/apache/iceberg/pull/18110#discussion_r4023283291) 
and it is suggested that this endpoint [should be used to presign FILE type 
urls as 
well](https://github.com/apache/iceberg/pull/17332#discussion_r3992139348).
   
   So, it seems to me that with presign, we are expecting the flow to be stg 
like: a FILE column stores `s3://bucket/images/123.jpg`; at read time, the 
client asks the catalog to pre-sign that location; the result is stg like 
`https://…?X-Amz-Signature=…` which is passed to the "inference service" and 
then thrown away.
   
   But if the goal is indeed to provide an `s3://...` URL and get a pre-signed 
`https://...` URL back, I'd advocate that this endpoint is not suitable, 
because it's not what it does today.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to