adutra commented on code in PR #18754: URL: https://github.com/apache/iceberg/pull/18754#discussion_r4511412227
########## core/src/main/java/org/apache/iceberg/rest/auth/BearerAuthConfig.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.auth; + +import java.nio.file.Path; +import java.nio.file.Paths; +import java.time.Duration; +import java.time.format.DateTimeParseException; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** Configuration for the {@link BearerAuthManager}. */ +record BearerAuthConfig( + @Nullable Path tokenFile, @Nullable Duration reloadInterval, @Nullable String token) { + + static final String BEARER_TOKEN = "rest.auth.bearer.token"; + static final String BEARER_TOKEN_FILE = "rest.auth.bearer.token-file"; + static final String BEARER_TOKEN_FILE_RELOAD_INTERVAL = + "rest.auth.bearer.token-file.reload-interval"; + + static final Duration DEFAULT_RELOAD_INTERVAL = Duration.ofMinutes(1); + static final Duration MIN_RELOAD_INTERVAL = Duration.ofSeconds(1); + + BearerAuthConfig { + Preconditions.checkArgument( + tokenFile == null || token == null, + "Invalid bearer configuration: token file and static token are mutually exclusive"); + Preconditions.checkArgument( + tokenFile != null || token != null, + "Invalid bearer configuration: one of token file or static token is required"); + Preconditions.checkArgument( + tokenFile == null || reloadInterval != null, + "Invalid bearer configuration: reload interval is required when using a token file"); Review Comment: There is already a default: when `rest.auth.bearer.token-file.reload-interval` isn't set, it's 1 minute, and users can override it. The check here only keeps the record consistent: `fromProperties()` always provides both the file and the interval, or none at all. As for 1 hour vs 1 minute: the interval bounds how long a rotated token can go unnoticed, so it needs to be well below the token's lifetime. Kubernetes projected tokens can live as little as 10 minutes, so with a 1-hour interval we'd keep sending expired tokens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
