pvary edited a comment on pull request #2171: URL: https://github.com/apache/iceberg/pull/2171#issuecomment-769711970
> BTW, do we need to change [this assert](https://github.com/apache/iceberg/blob/19622dcfcb426485748fa017a6181e23df5732dc/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java#L112-L118) currently since this issue happens no matter whether `hive.vectorized.execution.enabled` is enabled ? Testing vectorization is hard. Even if we turn on vectorization we have to check the output of `EXPLAIN VECTORIZATION <QUERY>` to check if the vectorization is actually happening or not, but if you can add a test case which fails even with vectorization disabled that's a good indicator that we definitely need TEZ-4248 or some other solution, and helps investigating the problem ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
