xanderbailey commented on code in PR #3659:
URL: https://github.com/apache/iceberg-rust/pull/3659#discussion_r4516339703
##########
crates/iceberg/src/encryption/manager.rs:
##########
@@ -125,6 +121,14 @@ impl EncryptionManager {
return Ok(None);
};
+ if metadata.format_version() < FormatVersion::V3 {
+ return Err(invalid_data!(
+ "Invalid properties for {}: {}",
Review Comment:
This matches iceberg-python's `EncryptionManager.from_table_metadata`
exactly, and uses the same wording as Java's
`EncryptionUtil.checkCompatibility` (Java prints the property set, so it reads
`Invalid properties for v2: [encryption.key-id]`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
