mengna-lin commented on code in PR #18477:
URL: https://github.com/apache/iceberg/pull/18477#discussion_r4516913888


##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -82,8 +85,12 @@ public class ExpireSnapshotsSparkAction extends 
BaseSparkAction<ExpireSnapshotsS
   private Dataset<FileInfo> expiredFileDS = null;
   private Boolean cleanExpiredMetadata = null;
 
+  private final Set<String> missingManifestListLocations = 
Sets.newConcurrentHashSet();
+  private final SetAccumulator<String> missingManifests = new 
SetAccumulator<>();
+
   ExpireSnapshotsSparkAction(SparkSession spark, Table table) {
     super(spark);
+    spark.sparkContext().register(missingManifests, 
"expire-snapshots-missing-manifests");

Review Comment:
   I have removed the accumulator. Now each missing file has one warning level 
log. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to