AynSiddiqui opened a new pull request, #2476: URL: https://github.com/apache/iceberg-go/pull/2476
Follow-up to #2456, as discussed in [this review thread](https://github.com/apache/iceberg-go/pull/2456#discussion_r4501992698). Step 2 of the README's Integration tests section sets `AWS_S3_ENDPOINT` to the `object-store` container IP. On Docker Desktop (macOS, Windows) the host can't reach container IPs, so S3 calls hang until they time out. This changes it to `http://localhost:9000`, the published port, matching CONTRIBUTING and `recipe.Start`. Docs only. `make integration-env` and the CI workflow still use the container IP and work on Linux runners, so they are unchanged. Tested on Linux: started `object-store` and `create-bucket`, exported `AWS_S3_ENDPOINT=http://localhost:9000 AWS_REGION=us-east-1`, and `go test -tags integration ./io/gocloud/s3/...` passed. Not tested on Docker Desktop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
