slachiewicz opened a new issue, #2486: URL: https://github.com/apache/iceberg-go/issues/2486
### Apache Iceberg version main (development) ### Please describe the bug 🐞 When the server doesn't advertise an endpoint, the REST client returns `rest.ErrEndpointNotSupported`, which doesn't wrap `iceberg.ErrNotImplemented`. A server that answers 501 for the same call does produce `ErrNotImplemented`, so callers have to check for both. It also means `catalogtest` can't run against a REST server that leaves an optional endpoint out. With `SupportsRenameTable: false`, `RenameTableNotSupported` asserts `ErrorIs(err, iceberg.ErrNotImplemented)` (`catalog/catalogtest/tables.go:117`), and the update calls in `NamespacePropertiesNotSupported` do the same (`namespaces.go:195`, `:198`). Proposal: wrap it, as `table.ErrWriteIORequired` already does. `errors.Is(err, rest.ErrEndpointNotSupported)` keeps working; the message gains a `not implemented: ` prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
