rdblue commented on code in PR #18853: URL: https://github.com/apache/iceberg/pull/18853#discussion_r4519597864
########## core/src/test/java/org/apache/iceberg/TestV4TrackedFileWrappers.java: ########## @@ -0,0 +1,810 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.apache.iceberg.V4TestHelpers.ADDED_TRACKING; +import static org.apache.iceberg.V4TestHelpers.columnFile; +import static org.apache.iceberg.V4TestHelpers.copyWithTracking; +import static org.apache.iceberg.V4TestHelpers.dataFile; +import static org.apache.iceberg.V4TestHelpers.dataFileWithColumnFiles; +import static org.apache.iceberg.V4TestHelpers.dataFileWithStats; +import static org.apache.iceberg.V4TestHelpers.deletionVector; +import static org.apache.iceberg.V4TestHelpers.manifestRef; +import static org.apache.iceberg.V4TestHelpers.manifestRefWithStats; +import static org.apache.iceberg.V4TestHelpers.partition; +import static org.apache.iceberg.V4TestHelpers.readTrackedFiles; +import static org.apache.iceberg.V4TestHelpers.writeTrackedFiles; +import static org.apache.iceberg.types.Types.NestedField.optional; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Map; +import org.apache.iceberg.V4Metadata.LeafTrackedFileWrapper; +import org.apache.iceberg.V4Metadata.RootTrackedFileWrapper; +import org.apache.iceberg.inmemory.InMemoryFileIO; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.transforms.Transforms; +import org.apache.iceberg.types.Comparators; +import org.apache.iceberg.types.Conversions; +import org.apache.iceberg.types.Types; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +class TestV4TrackedFileWrappers { Review Comment: @stevenzwu can you post the test plan? Do we need a test plan? I would expect these wrappers to be embedded in the root and leaf file writers, so validating the writer automatically validates the wrapper. I don't think that we have specific wrapper tests for the other versions, but a test for get-by-position is fine if you want to have them. I think we should keep this minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
