szehon-ho commented on code in PR #3662:
URL: https://github.com/apache/iceberg-rust/pull/3662#discussion_r4520106656
##########
crates/iceberg/src/transaction/snapshot/simple.rs:
##########
@@ -180,28 +178,25 @@ impl SimpleSnapshotProducer {
self.validate_added_data_files(table)?;
- // Allocate every path before writing, so each is recorded as owned
- // even if the write fails part-way: the path is write-once and a
- // partial file is an orphan to clean up like any other.
- //
- // TODO(#3500): group the files by partition spec and write one
- // manifest per group.
+ // BTreeMap keeps added manifests in deterministic partition spec
order.
+ let mut files_by_spec: BTreeMap<i32, Vec<&DataFile>> = BTreeMap::new();
Review Comment:
note: this is a bit different than java (hashmap) but explicitly specified
in #3500 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
