adiranjan25 commented on PR #18813: URL: https://github.com/apache/iceberg/pull/18813#issuecomment-6759564850
Thanks @Rishavbhattarai for the detailed review and for identifying the additional signed-zero edge cases. I've addressed the `ResidualEvaluator` issue in commit `a19dce4f4`. The update: - Uses `PredicateComparisons.compare()` for all six comparison predicates. - Uses `PredicateComparisons.contains()` for `IN` and `NOT IN`. - Adds regression coverage for both Float and Double identity partitions, including both signed-zero directions and all eight predicates. Local validation passed: - `:iceberg-api:spotlessApply` - `:iceberg-api:test --tests org.apache.iceberg.transforms.TestResiduals` The updated CI checks are currently running. I plan to keep the Parquet dictionary-filter issue as a separate follow-up to keep this PR focused on API correctness. Thanks again for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
