manuzhang commented on code in PR #1104:
URL: https://github.com/apache/iceberg-cpp/pull/1104#discussion_r4523039045
##########
src/iceberg/update/expire_snapshots.cc:
##########
@@ -918,6 +918,8 @@ Result<ExpireSnapshots::SnapshotToRef>
ExpireSnapshots::ComputeRetainedRefs(
}
Result<ExpireSnapshots::ApplyResult> ExpireSnapshots::Apply() {
+ // A no-op apply must not leave an earlier cleanup plan active.
+ apply_result_.reset();
Review Comment:
I'm a bit confused with cleaning up here while inheriting an empty
`PrepareForReplay`. It looks me clearer to me with calling `CleanStaged` in
`PrepareForReplay`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
