badalprasadsingh commented on code in PR #2475:
URL: https://github.com/apache/iceberg-go/pull/2475#discussion_r4527608123
##########
table/metadata.go:
##########
@@ -3693,6 +3686,12 @@ func NewMetadataWithUUID(sc *iceberg.Schema, partitions
*iceberg.PartitionSpec,
return nil, err
}
+ // reassignIDs looks up partition and sort columns by ID, so each ID
must
+ // point to one field (#2393).
+ if err := iceberg.ValidateUniqueFieldIDs(sc); err != nil {
+ return nil, err
+ }
Review Comment:
this also rejects unpartitioned, unsorted schemas where fields share ID 0 or
-1: somethingt which worked before on every catalog except rest
add a note under "Unreleased compatibility notes" in
`website/src/releases.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
