FenjuFu commented on PR #1106:
URL: https://github.com/apache/iceberg-cpp/pull/1106#issuecomment-6773939326
Checked both suggestions against the full script at 81cd7dd1. The
required-argument guard immediately above the new case block already rejects an
empty cxx_standard with exit 2, before any directory operations. The mkdir
creates the parent of build/cxx${cxx_standard}; the subsequent cleanup and
non-recursive mkdir deliberately operate on the per-standard child, so a failed
cleanup cannot silently reuse it.
These are maintainability suggestions rather than demonstrated failures in
the current flow, so I have left the implementation unchanged. The current head
has 14 successful checks, including pre-commit and Windows C++20. That CI
result does not establish a real Windows file-lock reproduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
