Revanth14 opened a new pull request, #2496: URL: https://github.com/apache/iceberg-go/pull/2496
## Problem Part of #2062, following #2484. Call sites have to stop building `StructType`, `ListType` and `MapType` from field literals and stop reading `FieldList` directly before the fields are unexported for v1.0.0. This PR does that for the tests in `catalog`, `cmd` and `view`. ## Fix The change is generated by the same `go/ast` rewriter as #2484. 34 pointer literals become `iceberg.NewStructType`, `NewListType` and `NewMapType` calls, and 5 `FieldList[0]` reads become `Field(0)`. There are no hand edits. Left as they are: the three writes through `FieldList` in `view/metadata_test.go` (`TestCloneSchemaCopiesNestedValues`), which check that `cloneSchema` doesn't share nested types with the original. Making `cloneSchema` shallow still fails the test after the rewrite. Like the ones listed on #2484, they move when the fields are unexported. ## Testing No behavior change; tests only. gofmt, `go vet ./...`, `go vet -tags integration ./catalog/...` and `go test -race ./...` pass locally. The integration tests were not run locally. Lint was not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
