kevinjqliu commented on code in PR #3666:
URL: https://github.com/apache/iceberg-rust/pull/3666#discussion_r4528266909
##########
crates/catalog/rest/Cargo.toml:
##########
@@ -44,7 +44,7 @@ http = { workspace = true }
iceberg = { workspace = true }
itertools = { workspace = true }
moka = { workspace = true, features = ["sync"] }
-reqwest = { workspace = true }
+reqwest = { workspace = true, features = ["form", "query"] }
Review Comment:
Reqwest 0.13 made `form` and `query` opt-in features ([breaking
changes](https://github.com/seanmonstar/reqwest/releases/tag/v0.13.0)).
> query and form are now crate features, disabled by default.
Both are required by existing REST catalog code:
- [`form`: OAuth token
requests](https://github.com/apache/iceberg-rust/blob/e03303b183e08a32e577dfb9d93d1512506e2089/crates/catalog/rest/src/client.rs#L75-L79).
- [`query`: warehouse
selection](https://github.com/apache/iceberg-rust/blob/e03303b183e08a32e577dfb9d93d1512506e2089/crates/catalog/rest/src/catalog.rs#L652),
[purge
requests](https://github.com/apache/iceberg-rust/blob/e03303b183e08a32e577dfb9d93d1512506e2089/crates/catalog/rest/src/catalog.rs#L876),
and
[pagination](https://github.com/apache/iceberg-rust/blob/e03303b183e08a32e577dfb9d93d1512506e2089/crates/catalog/rest/src/catalog.rs#L1047-L1056).
Enabling these features preserves compilation after the upgrade.
##########
Cargo.toml:
##########
@@ -127,7 +127,7 @@ pyo3 = "0.29"
quote = "1"
rand = "0.9.3"
regex = "1.11.3"
-reqwest = { version = "0.12.12", default-features = false, features = ["json"]
}
+reqwest = { version = "0.13.5", default-features = false, features = ["json"] }
Review Comment:
This changes the public APIs that accept reqwest clients, requests, or
errors to require 0.13 types. Downstream callers using those APIs must upgrade;
callers using the default client are unaffected.
##########
Cargo.toml:
##########
@@ -127,7 +127,7 @@ pyo3 = "0.29"
quote = "1"
rand = "0.9.3"
regex = "1.11.3"
-reqwest = { version = "0.12.12", default-features = false, features = ["json"]
}
+reqwest = { version = "0.13.5", default-features = false, features = ["json"] }
Review Comment:
i made an edit in pr description to highlight this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
