zeroshade commented on PR #2494: URL: https://github.com/apache/iceberg-go/pull/2494#issuecomment-6776227613
Follow-up: merged with current `main`, `./view` fails (14 tests, e.g. `TestUnmarshalViewMetadata`) because the shared `exampleViewJSON` fixture in `view/metadata_test.go` declares a `long` field with `"initial-default": true` and `"write-default": true`. The new check correctly rejects that; could you change both to a long value (e.g. `1`) in this PR? I missed `./view` in my local run, sorry about that. --- > *This review was drafted by an AI-assisted tool and confirmed by an Apache Iceberg Go maintainer. The findings below are observations, not blockers; an Apache Iceberg Go maintainer — a real person — will take the next look at the PR. If you think a finding is mis-applied, please reply on the PR and a maintainer will weigh in.* > > *More on how Apache Iceberg Go handles maintainer review:* [CONTRIBUTING.md](https://github.com/apache/iceberg-go/blob/main/CONTRIBUTING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
