szehon-ho commented on PR #18879: URL: https://github.com/apache/iceberg/pull/18879#issuecomment-6785030927
i think mostly looks good, but can you explain the rationale for some of the impl decisions? - Arc-containment checks use a 1e-12 tolerance. - Cross-product lengths at or below 1e-6 trigger conservative handling: nearly antipodal endpoints produce world bounds; short arcs get latitude padding based on their angular length. - Computed latitude extrema are widened outward by the larger of 1e-6° or a 1e-7 relative margin, clamped to ±90°. - Longitude coverage follows the shorter circular interval (the shorter one around the world), representing antimeridian crossings with west > east. Computed bounds reaching a pole expand to all longitudes. we can discuss and should probably comment some of them if they make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
