CTTY commented on code in PR #3670:
URL: https://github.com/apache/iceberg-rust/pull/3670#discussion_r4534127903
##########
crates/iceberg/src/spec/manifest/reader.rs:
##########
@@ -19,18 +19,29 @@ use super::Manifest;
use crate::encryption::{EncryptedInputFile, StandardKeyMetadata};
use crate::error::{Result, invalid_data};
use crate::io::FileIO;
+use crate::runtime::Runtime;
use crate::spec::{ManifestContentType, ManifestEntry, ManifestFile};
/// Reads a manifest file referenced by a manifest list entry, transparently
/// decrypting it when the entry records key metadata.
pub struct ManifestReader {
file_io: FileIO,
+ runtime: Option<Runtime>,
Review Comment:
I'm leaning towards making runtime non-optional to avoid future performance
issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
