Fokko commented on code in PR #16214: URL: https://github.com/apache/iceberg/pull/16214#discussion_r4535880236
########## docker/iceberg-rest-fixture/entrypoint.sh: ########## @@ -20,7 +20,8 @@ set -eu -CLASSPATH="iceberg-rest-adapter.jar" +# The staged runtime puts all REST server jars under libs/; Java expands this wildcard. +CLASSPATH="libs/*" Review Comment: Is LOG_LEVEL still picked up? The staged libs contain both slf4j-simple and log4j-slf4j-impl (the latter via hadoop-common), and with two SLF4J providers the one with the higher priority wins, which I believe is log4j. That would make the simpleLogger property a no-op. Is this on purpose? Any way to verify with tests that we don't change behavior? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
