JosephLenton commented on code in PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#discussion_r4538123374
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -271,9 +272,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
PrimitiveType::TimestampNs => AvroSchema::TimestampNanos,
PrimitiveType::TimestamptzNs => AvroSchema::TimestampNanos,
PrimitiveType::String => AvroSchema::String,
- // TODO(#2913): write the spec's `fixed[16]` uuid. The manifest
reader
- // already accepts both forms.
- PrimitiveType::Uuid => AvroSchema::Uuid(UuidSchema::String),
+ PrimitiveType::Uuid => self.define_once(avro_uuid_schema()?),
Review Comment:
I believe this is already covered. For example there is a test here that
reads a Fixed 16 + `logical_type=uuid`, and it is read back as a UUID type.
https://github.com/apache/iceberg-rust/blob/cfbfb2789fb8899f3ffceef25e168ad04ab3a5d7/crates/iceberg/src/avro/schema.rs#L1318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
