Fokko commented on code in PR #3972:
URL: https://github.com/apache/iceberg-python/pull/3972#discussion_r4541470322
##########
pyiceberg/manifest.py:
##########
@@ -916,12 +920,21 @@ def fetch_manifest_entry(
read_enums={0: ManifestEntryStatus, 101: FileFormat, 134:
DataFileContent},
) as reader:
result = []
+ next_row_id = self.first_row_id if self.content ==
ManifestContent.DATA else None
for entry in reader:
if discard_deleted and entry.status ==
ManifestEntryStatus.DELETED:
continue
_inherit_from_manifest(entry, self)
+ # Inherit first row IDs, which are only valid when a data
manifest has a first_row_id
+ data_file = entry.data_file
+ if next_row_id is None:
+ data_file.first_row_id = None
+ elif entry.status != ManifestEntryStatus.DELETED and
data_file.first_row_id is None:
Review Comment:
I think it would be nice to have something similar in Java: `entry.is_live()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
