rahulsmahadev commented on code in PR #4345:
URL: https://github.com/apache/iceberg-python/pull/4345#discussion_r4541830555
##########
tests/table/test_commit_retry.py:
##########
@@ -207,6 +207,47 @@ def
test_concurrent_append_delete_raises_validation_exception(catalog: Catalog)
tbl2.delete("x == 1")
+def
test_concurrent_append_case_insensitive_delete_retries_successfully(catalog:
Catalog) -> None:
Review Comment:
Thanks, added in c8440611. All of these fail on main and pass with this
change:
-
`test_snapshot_isolation_case_insensitive_delete_after_concurrent_delete_retries_successfully`
and `..._raises_validation_exception` in `tests/table/test_commit_retry.py`:
snapshot isolation, a concurrent delete, then the case-insensitive delete.
These reach `_validate_deleted_data_files` and `_validate_no_new_delete_files`,
which the serializable tests did not.
- `test_added_delete_files_case_insensitive_filter` in
`tests/table/test_validate.py`: a mixed-case filter with `case_sensitive=False`
against delete-file manifests, through `_added_delete_files` and
`_validate_no_new_delete_files`, and a check that the default case-sensitive
binding still rejects it.
Agreed that carrying the binding setting with the filter would avoid the
plumbing; happy to look at that as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
