Fokko commented on code in PR #4065:
URL: https://github.com/apache/iceberg-python/pull/4065#discussion_r4543234965
##########
tests/integration/test_reads.py:
##########
@@ -1001,10 +1001,7 @@ def test_null_list_and_map(catalog: Catalog) -> None:
arrow_table = table_test_empty_list_and_map.scan().to_arrow()
assert arrow_table["col_list"].to_pylist() == [None, []]
assert arrow_table["col_map"].to_pylist() == [None, []]
- # This should be:
- # assert arrow_table["col_list_with_struct"].to_pylist() == [None,
[{'test': 1}]]
- # Once https://github.com/apache/arrow/issues/38809 has been fixed
- assert arrow_table["col_list_with_struct"].to_pylist() == [[], [{"test":
1}]]
+ assert arrow_table["col_list_with_struct"].to_pylist() == [None, [{"test":
1}]]
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
