ewoodbury commented on code in PR #3438:
URL: https://github.com/apache/iceberg-rust/pull/3438#discussion_r4544231435


##########
crates/iceberg/src/arrow/reader/projection.rs:
##########
@@ -69,22 +70,30 @@ impl ArrowReader {
 
     /// Recursively extract leaf field IDs because Parquet projection works at 
the leaf column level.
     /// Nested types (struct/list/map) are flattened in Parquet's columnar 
format.
-    fn include_leaf_field_id(field: &NestedField, field_ids: &mut Vec<i32>) {
+    /// Also collects the ids of non-empty structs, which may need a presence 
leaf.
+    fn include_leaf_field_id(

Review Comment:
   Makes sense, done - it's now `ProjectedFields::include`, with leaf_ids kept 
as a `Vec`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to