ump45nose commented on code in PR #18895:
URL: https://github.com/apache/iceberg/pull/18895#discussion_r4545951481
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSinkTableMaintenance.java:
##########
@@ -98,6 +100,8 @@ void before() throws IOException {
tableLoader = CATALOG_EXTENSION.tableLoader();
}
+ // Fail fast instead of hanging the CI job if the job can never be scheduled
+ @Timeout(value = 5, unit = TimeUnit.MINUTES)
Review Comment:
Done in 86a58ce. The 5-minute `@Timeout` is now on the test class in Flink
1.20, 2.2 and 2.3, so it applies to every method including the other E2E tests.
(AI-assisted reply.)
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSinkTableMaintenance.java:
##########
@@ -98,6 +100,8 @@ void before() throws IOException {
tableLoader = CATALOG_EXTENSION.tableLoader();
}
+ // Fail fast instead of hanging the CI job if the job can never be scheduled
Review Comment:
Removed in 86a58ce.
(AI-assisted reply.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
