blackmwk commented on code in PR #3283:
URL: https://github.com/apache/iceberg-rust/pull/3283#discussion_r4548020273
##########
crates/iceberg/src/encryption/io.rs:
##########
@@ -74,8 +74,22 @@ impl EncryptedInputFile {
/// Creates a reader that transparently decrypts on each read.
pub async fn reader(&self) -> Result<Box<dyn FileRead>> {
+ // Identity just returns the file reader it was given.
+ self.reader_with_wrapper(std::convert::identity).await
+ }
+
+ /// Creates a decrypting reader, letting the caller wrap the file reader
first.
+ ///
+ /// Calls `wrap` once with the file reader and uses the result for
decryption.
+ /// This lets callers add behavior such as logging reads or counting bytes
+ /// without changing the decryption code.
+ pub(crate) async fn reader_with_wrapper<F, R>(&self, wrap: F) ->
Result<Box<dyn FileRead>>
+ where
+ F: FnOnce(Box<dyn FileRead>) -> R,
+ R: FileRead,
+ {
let encrypted_length = self.encrypted_length()?;
- let raw_reader = self.inner.reader().await?;
+ let raw_reader = Box::new(wrap(self.inner.reader().await?));
Review Comment:
Hmm, why F must take a Box? I was thinking F has following signature:
```rust
F: FnOnce(impl FileRead) -> R
```
We only need to add `impl FileRead for Box<dyn FileRead>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
