romandenysov-akv commented on PR #17: URL: https://github.com/apache/iceberg-verification/pull/17#issuecomment-6825285586
> `dev/validate-fixtures.py` now recomputes every bucket value, and the README example has `null` first, thanks. Could you open an issue for recomputing truncate and the temporal transforms? The bucket-coverage follow-up could also take pre-epoch year/month/hour points at 1969-01-01, 1968-12-31 and 1969-12-31T23:00:00, which catch a truncate-then-subtract-one implementation. The validator notes inline are yours to handle here or in a follow-up. @laskoviymishka Thanks for the suggestion. I opened #23 to track the truncate and temporal validation and the additional pre-epoch cases. The other comments resolved, it's lgtm to finish PR from my perspective. Pls let me know if I missed something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
