adutra commented on code in PR #17914:
URL: https://github.com/apache/iceberg/pull/17914#discussion_r4554009354
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -279,7 +281,7 @@ public SdkHttpFullRequest sign(
.build();
Key cacheKey = Key.from(remoteSigningRequest);
- SignedComponent cachedSignedComponent =
SIGNED_COMPONENT_CACHE.getIfPresent(cacheKey);
+ SignedComponent cachedSignedComponent =
signedComponentCache().getIfPresent(cacheKey);
Review Comment:
> are we treating remote-signing-config a credential now ?
Not "credential" necessarily, but at least like something that must be part
of the cache key. We don't known what it contains and whether a specific server
sends information there that is relevant for the signing operation; mixing
cache entries that contain different remote-signing-configs is therefore risky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
