badalprasadsingh commented on code in PR #2515:
URL: https://github.com/apache/iceberg-go/pull/2515#discussion_r4553918432


##########
website/src/releases.md:
##########
@@ -48,6 +48,7 @@ Per-release notes (highlights, breaking changes, 
contributors) are published on
 - **Sort order replacements reuse orders staged earlier in the same 
transaction.** If a transaction replaces order A with B and then returns to A, 
A becomes the default again instead of B. The final update reuses A's ID 
instead of adding another definition. Reuse of orders from earlier commits was 
already supported.
 - **Case-insensitive field binding rejects only ambiguous names.** 
`Reference.Bind` and `Schema.Select` return `ErrInvalidSchema` when the 
requested case-insensitive name matches different field IDs, and the error 
includes both names. Unrelated names remain available to scans, writes, and 
schema, partition, and sort order updates.
 - **Delete files now have a separate 64 MiB target.** Equality-delete and v2 
position-delete files previously used `write.target-file-size-bytes` (512 MiB 
by default, or the table's override) as their file-size target. They now use 
`write.delete.target-file-size-bytes`, which defaults to 64 MiB. After 
upgrading, tables may produce more, smaller delete files unless this new 
property is set. To preserve the previous delete-file size target, set 
`write.delete.target-file-size-bytes` to the table's former effective 
`write.target-file-size-bytes` value (`536870912` when the data-file target was 
unset). The data-file target itself is unchanged.
+- **Schema updates reject read-time type casts.** `UpdateSchema.UpdateColumn` 
now allows only Iceberg schema promotions. Changes such as `string` to `binary` 
and `fixed[16]` to `uuid` are rejected by default. Set 
`allowIncompatibleChanges` to `true` in `NewUpdateSchema` to allow these 
changes explicitly.

Review Comment:
   sorry, my previous comment was unclear: please drop the last sentence 
   
   `allowIncompatibleChanges` turns this check off, but data files stay as they 
are -> thus, these changes commit and iceberg-go reads break: after fixed[16] 
to uuid, scans of that column fail
   
   iceberg-java's `UpdateSchema` rejects them even with 
`allowIncompatibleChanges()`
   
   ```md
   - **Schema updates reject read-time type casts.** 
`UpdateSchema.UpdateColumn` now allows only Iceberg schema promotions. Changes 
such as `string` to `binary` and `fixed[16]` to `uuid` are rejected by default.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to