hcrosse commented on PR #4278: URL: https://github.com/apache/iceberg-python/pull/4278#issuecomment-6832465418
@Fokko, thanks for the patch. I applied it verbatim. Java's `ResidualEvaluator` returns `alwaysTrue` for `notEq`, `notIn` and `notNaN` on NULL. [`TestResiduals`](https://github.com/apache/iceberg/blob/acea99d28a4be93a8c0dfc7bd8ece4a237324243/api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java#L251-L290) asserts that "null not in" is true. Your patch also reverses the `NotNaN` expectation from #3689. Are you fine diverging from Java here? The REST test that you removed covered a different case. Without `residual-filter`, PyIceberg uses `AlwaysTrue`, so `count()` trusts `record_count`. In that test, `count()` returns 3 on main and with your patch, while `to_arrow()` returns 0. The [REST spec](https://github.com/apache/iceberg/blob/acea99d28a4be93a8c0dfc7bd8ece4a237324243/open-api/rest-catalog-open-api.yaml#L5853-L5858) requires the client to compute the residual or use the original filter. Would you like me to fix that here or in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
