vladislav-sidorovich commented on PR #16848: URL: https://github.com/apache/iceberg/pull/16848#issuecomment-6836741012
> I don't think I agree with this assessment. The issue in the referenced PR is caused by a different issue (cache key collisions) not a race condition around the initialization of the auth manager. @danielcweeks Fair point — the main bug in #14178 was cache key collisions (I was referring only to the `volatile / synchronized (this) lazy init` added in that PR for standalone multi-threaded callers, since GoogleAuthManager delegates tableSession(RESTClient, Map) to catalogSession -> initialize). Since all review comments have been addressed, could you please clarify how you'd like to proceed: should this PR be merged, or should it not be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
