amogh-jahagirdar commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4556641757


##########
core/src/main/java/org/apache/iceberg/RootManifestFile.java:
##########
@@ -21,14 +21,31 @@
 import java.nio.ByteBuffer;
 import java.util.Arrays;
 import java.util.List;
+import org.apache.iceberg.io.FileIO;
 import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 import org.apache.iceberg.util.ByteBuffers;
+import org.apache.iceberg.util.LocationUtil;
 
 /** A {@link ManifestFile} for the root manifest of an adaptive metadata tree. 
*/
 class RootManifestFile implements ManifestFile {
   private static final int FORMAT_VERSION = 4;
 
+  static RootManifestFile from(Snapshot snapshot, FileIO io, String 
tableLocation) {
+    if (snapshot.keyId() != null) {
+      throw new UnsupportedOperationException("Encrypted v4 root manifests are 
not supported");
+    }
+
+    String location = LocationUtil.resolveLocation(tableLocation, 
snapshot.rootManifestLocation());
+    return new RootManifestFile(
+        location,
+        io.newInputFile(location).getLength(),

Review Comment:
   At some point for the encryption work iirc we'd store the root manifest 
length in the snapshot right? But I agree with making progress here independent 
of that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to