kevinjqliu commented on code in PR #18899:
URL: https://github.com/apache/iceberg/pull/18899#discussion_r4554851682
##########
build.gradle:
##########
@@ -1216,11 +1216,41 @@ project(':iceberg-open-api') {
}
check.dependsOn('validateRESTCatalogSpec')
+ // Runtime JARs for the iceberg-rest-fixture Docker image
+ configurations {
+ restFixtureRuntime {
Review Comment:
split into its own config for easier management
##########
build.gradle:
##########
@@ -1216,11 +1216,41 @@ project(':iceberg-open-api') {
}
check.dependsOn('validateRESTCatalogSpec')
+ // Runtime JARs for the iceberg-rest-fixture Docker image
+ configurations {
+ restFixtureRuntime {
+ canBeConsumed = false
+ extendsFrom testFixturesImplementation
+ exclude group: 'org.apache.hadoop', module: 'hadoop-annotations'
+ exclude group: 'org.apache.hadoop.thirdparty', module:
'hadoop-shaded-protobuf_3_25'
+ exclude group: 'org.apache.commons', module: 'commons-math3'
+ exclude group: 'org.apache.commons', module: 'commons-text'
+ exclude group: 'org.apache.httpcomponents'
+ exclude group: 'commons-logging'
+ exclude group: 'commons-net'
+ exclude group: 'javax.servlet'
+ exclude group: 'javax.servlet.jsp'
+ exclude group: 'jakarta.activation'
+ exclude group: 'org.codehaus.jettison'
+ exclude group: 'org.bouncycastle'
+ exclude group: 'com.nimbusds'
+ exclude group: 'io.netty'
+ exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
+ exclude group: 'org.jspecify', module: 'jspecify'
+ }
+ }
+
+ dependencies {
+ restFixtureRuntime project(path: ':iceberg-aws-bundle', configuration:
'shadow')
+ restFixtureRuntime project(path: ':iceberg-azure-bundle', configuration:
'shadow')
+ restFixtureRuntime project(path: ':iceberg-gcp-bundle', configuration:
'shadow')
Review Comment:
so we can reuse the cloud bundles license and notice files
this is how we generally support cloud file ios
##########
build.gradle:
##########
@@ -1174,9 +1173,8 @@ project(':iceberg-open-api') {
exclude group: 'commons-cli', module: 'commons-cli'
exclude group: 'com.github.pjfanning', module: 'jersey-json'
}
- testFixturesRuntimeOnly
'org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.6.0'
+ testFixturesImplementation
'org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.6.0'
testFixturesImplementation project(path: ':iceberg-bundled-guava',
configuration: 'shadow')
- testFixturesImplementation libs.junit.jupiter
Review Comment:
moved to L1188 from `testFixturesImplementation` -> `testFixturesCompileOnly`
##########
build.gradle:
##########
@@ -1174,9 +1173,8 @@ project(':iceberg-open-api') {
exclude group: 'commons-cli', module: 'commons-cli'
exclude group: 'com.github.pjfanning', module: 'jersey-json'
}
- testFixturesRuntimeOnly
'org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.6.0'
+ testFixturesImplementation
'org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.6.0'
Review Comment:
so the rest fixture also picks up the override
##########
build.gradle:
##########
@@ -1151,7 +1151,6 @@ project(':iceberg-open-api') {
testFixturesImplementation project(path: ':iceberg-core', configuration:
'testArtifacts')
testFixturesImplementation project(':iceberg-aws')
testFixturesImplementation project(':iceberg-gcp')
- testFixturesImplementation project(':iceberg-bigquery')
Review Comment:
i believe this was added by accident in
https://github.com/apache/iceberg/commit/2b9a7e3fd42c8ab82d053760bced09cdbf82a1cf
we dont need bigquery deps in the docker image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]