PiyushHurpadeDremio commented on a change in pull request #2182:
URL: https://github.com/apache/iceberg/pull/2182#discussion_r567574823
##########
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##########
@@ -147,6 +152,22 @@ private ManifestFile copyManifest(ManifestFile manifest) {
return newManifests;
}
+ @Override
+ protected Map<Integer, String> updatePartitionStats() {
+ Map<Integer, String> newPartitionStatsLocations = new HashMap<>();
+ int currentSpecID = ops.current().spec().specId();
+ List<PartitionStatsEntry> oldStatsEntries =
getOldPartitionStatsBySpec(currentSpecID);
+ PartitionsTable.PartitionMap partitionMap =
partitionStatsMap.getPartitionMap(currentSpecID);
+ if (Objects.isNull(partitionMap)) {
+ partitionMap = partitionStatsMap.getEmptyPartitionMap(currentSpecID);
Review comment:
schema changes will be part of UpdateSchema.java interface. Above code
is only for FastAppend operation. We don't require to create new stats file.
This PR implementation will not create new partition stats file. as
UpdateSchema only updates table metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
