zhjwpku commented on code in PR #1119: URL: https://github.com/apache/iceberg-cpp/pull/1119#discussion_r4560769022
########## mkdocs/docs/getting-started.md: ########## @@ -39,6 +39,10 @@ ctest --test-dir build --output-on-failure ## Build with CMake +Dependencies managed with CMake FetchContent use the pinned sources by default. +Set `-DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=OPT_IN` to try installed packages before Review Comment: I'm wondering when user set this to OPT_IN with a unsupported installed package, will it pass the cmake configuration phase? If yes, should we error out earlier by adding versions to `FIND_PACKAGE_ARGS`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
