manuzhang commented on code in PR #1114:
URL: https://github.com/apache/iceberg-cpp/pull/1114#discussion_r4559217690
##########
src/iceberg/parquet/parquet_reader.cc:
##########
@@ -452,6 +457,13 @@ class ParquetReader::Impl {
auto row_group = metadata->RowGroup(row_group_index);
ICEBERG_ASSIGN_OR_RAISE(
auto should_read, stats_filter_->ShouldRead(reader_->manifest(),
*row_group));
+ if (should_read && bloom_filter_) {
+ auto bloom_reader =
+
reader_->parquet_reader()->GetBloomFilterReader().RowGroup(row_group_index);
Review Comment:
This can throw uncaught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]