GaspardMerten commented on PR #3862: URL: https://github.com/apache/iceberg-python/pull/3862#issuecomment-6857169321
Hey @Fokko, @rambleraptor! First of all, thank you for reopening the PR and for your feedback. Since #4334 landed in the meantime, I rebased on main and narrowed the PR to the two things that were left: - struct columns were still compared with the Python fallback. They are now compared field by field in PyArrow. - columns whose types differ are now cast before comparing. That covers a struct of `string` against the struct of `large_string` a scan returns (which is what kept structs in the Python fallback), and a naive against a zoned timestamp, which flagged every row as changed. This also resolves both review comments: the check on the source and target columns that raised a `ValueError` is gone, so an empty target returns an empty table as on main, and the tests no longer monkeypatch private functions; they only check the returned rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
