nastra commented on code in PR #18817:
URL: https://github.com/apache/iceberg/pull/18817#discussion_r4565723269


##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -182,4 +182,102 @@ public void 
resolvingFileIOWithStorageCredentialsSerialization(
         .isEqualTo(storageCredentials)
         .isEqualTo(resolvingFileIO.credentials());
   }
+
+  @Test
+  void delegateKeepsItsRefreshedCredentials() {
+    List<StorageCredential> initial =
+        ImmutableList.of(StorageCredential.create("prefix", Map.of("key", 
"initial")));
+    List<StorageCredential> refreshed =
+        ImmutableList.of(StorageCredential.create("prefix", Map.of("key", 
"refreshed")));
+    ResolvingFileIO resolvingFileIO = resolvingFileIOWithCredentialsDelegate();
+    resolvingFileIO.setCredentials(initial);
+
+    CredentialsDelegateFileIO delegate =
+        (CredentialsDelegateFileIO) resolvingFileIO.io("delegate://file");
+    assertThat(delegate.credentials()).isEqualTo(initial);
+
+    // the delegate refreshes its credentials without going through 
ResolvingFileIO
+    delegate.refreshCredentials(refreshed);
+    resolvingFileIO.newInputFile("delegate://file");
+
+    assertThat(resolvingFileIO.io("delegate://file")).isSameAs(delegate);
+    assertThat(delegate.credentials()).isEqualTo(refreshed);
+  }
+
+  @Test
+  void setCredentialsUpdatesExistingDelegates() {
+    List<StorageCredential> initial =
+        ImmutableList.of(StorageCredential.create("prefix", Map.of("key", 
"initial")));
+    List<StorageCredential> updated =
+        ImmutableList.of(StorageCredential.create("prefix", Map.of("key", 
"updated")));
+    ResolvingFileIO resolvingFileIO = resolvingFileIOWithCredentialsDelegate();
+    resolvingFileIO.setCredentials(initial);
+    CredentialsDelegateFileIO delegate =
+        (CredentialsDelegateFileIO) resolvingFileIO.io("delegate://file");
+
+    resolvingFileIO.setCredentials(updated);
+
+    assertThat(delegate.credentials()).isEqualTo(updated);
+    assertThat(resolvingFileIO.credentials()).isEqualTo(updated);
+  }
+
+  private static ResolvingFileIO resolvingFileIOWithCredentialsDelegate() {
+    ResolvingFileIO resolvingFileIO = spy(new ResolvingFileIO());
+    resolvingFileIO.setConf(new Configuration());
+    resolvingFileIO.initialize(ImmutableMap.of());
+    doReturn(CredentialsDelegateFileIO.class.getName())
+        .when(resolvingFileIO)
+        .implFromLocation(any());
+    return resolvingFileIO;
+  }
+
+  /**
+   * A delegate FileIO that stores the storage credentials it receives.
+   *
+   * <p>{@link CatalogUtil#loadFileIO} loads it by class name, so it must be 
public.
+   */

Review Comment:
   ```suggestion
   ```
   this isn't really adding any value, so let's omit it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to