zeroshade opened a new pull request, #2581:
URL: https://github.com/apache/iceberg-go/pull/2581

   `newNamespaceRaceCatalog` built its warehouse as `"file://" + path`. 
`TestRenameView` has two subtests that both join to `db.child` ({"db", "child"} 
and {"db.child"}), so Go names the second `db.child#01`, and `t.TempDir` keeps 
the `#` in its directory name. The `#` turned the rest of the warehouse URI 
into a fragment, so the view's location resolved to 
`$TMPDIR/TestRenameViewdb.child/...`, outside the test's temp directory. On a 
fresh machine the test passes but leaves files there. Once that stray directory 
exists, the next run fails with `open .../db.db/old: is a directory`.
   
   This builds the URI with `url.URL`, so the path is escaped (`#` becomes 
`%23`), and gives the `TestRenameView` subtests distinct names.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to