msabiransari commented on issue #18744: URL: https://github.com/apache/iceberg/issues/18744#issuecomment-6861530213
Thanks @Orcus01, yes, that would help. One clarification first: #18746 does not change the dependency guidance, it changes the code. `DefaultAwsClientFactory` builds `AwsProperties` on the first call to `glue()`, `kms()` or `dynamo()` instead of during `initialize`, so an S3-only classpath should no longer need `kms` and `sts`. The module's own tests cannot show that, because its test classpath always carries both. An independent run on a clean classpath is exactly the missing piece. The most useful comparison, using the `InitS3FileIO` program from the issue description: | `iceberg-aws` | AWS SDK modules on the classpath | Expected | |---|---|---| | 1.12.0 | `s3`, `url-connection-client` | `NoClassDefFoundError: software/amazon/awssdk/services/kms/model/EncryptionAlgorithmSpec` | | 1.12.0 | plus `kms` | `NoClassDefFoundError: software/amazon/awssdk/services/sts/model/Tag` | | 1.12.0 | plus `kms` and `sts` | `initialize OK` | | built from the PR branch | `s3`, `url-connection-client` | `initialize OK` | The fourth row is the one that matters for the review. None of them needs an AWS request. If you have time, please post the dependency list, the JDK and SDK versions and the output on #18746, so reviewers see it next to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
