kevinjqliu commented on PR #4292:
URL: https://github.com/apache/iceberg-python/pull/4292#issuecomment-6862112538

   thanks for the fix @ghoshp83! i pushed a commit on top 
(https://github.com/apache/iceberg-python/pull/4292/changes/9bf1f37d5176b2080f280955dc54b6c8e2a8f287)
 to clean things up a bit:
   
   - `ignore_residuals` -> `_ignore_residuals`. `ManifestGroupPlanner` shipped 
in 0.12.0, so the `_` prefix keeps the new param out of the public API (same as 
`_isolation_operation`). it now also sets residuals to `AlwaysTrue`, so the 
name matches what it does, similar to Java's `ignoreResiduals`
   - `Transaction.delete` plans directly from the branch head. 
`Transaction._scan` was only used here, so i removed it
   - moved the test to `tests/table/test_init.py` since its not really a 
catalog behavior. it reuses the existing position delete helper in 
`test_commit_retry.py` (now takes an optional `row`) instead of building the 
snapshot by hand
   
   also updated the pr description to "Part of #4291" since the retry conflict 
check (case 3) will be a follow up.
   
   lmk what you think! 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to