xanderbailey opened a new pull request, #4368:
URL: https://github.com/apache/iceberg-python/pull/4368

   <!--
   Thanks for opening a pull request!
   -->
   Working towards https://github.com/apache/iceberg-python/issues/3222
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   Follow-up from 
https://github.com/apache/iceberg-python/pull/4328#discussion_r4567555975: the 
encryption checks used `isinstance(..., TableMetadataV3)`, while the rest of 
the codebase compares `format_version`. This switches the encryption manager 
and the encryption key updates to `format_version < 3`.
   
   ## Are these changes tested?
   Covered by the existing tests for encryption on pre-v3 tables.
   
   ## Are there any user-facing changes?
   No.
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to