xanderbailey commented on code in PR #4328:
URL: https://github.com/apache/iceberg-python/pull/4328#discussion_r4567793339
##########
pyiceberg/io/fileformat.py:
##########
@@ -159,7 +160,10 @@ def create_writer(
output_file: OutputFile,
file_schema: Schema,
properties: Properties,
- ) -> FileFormatWriter: ...
+ key_metadata: StandardKeyMetadata | None = None,
Review Comment:
properties is per table where as key_metadata is per file so I'd a little
less inclined to put it in there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]