acruise commented on code in PR #15994:
URL: https://github.com/apache/iceberg/pull/15994#discussion_r4568237617


##########
api/src/main/java/org/apache/iceberg/udf/UdfType.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.udf;
+
+/**
+ * Represents a UDF data type as defined in the UDF spec. UDF types are based 
on Iceberg types but
+ * intentionally omit field IDs and element nullability. Concrete 
implementations live as static
+ * nested classes on {@link UdfTypes}: {@link UdfTypes.PrimitiveType} for 
primitive and
+ * semi-structured types, and the nested types {@link UdfTypes.ListType}, 
{@link UdfTypes.MapType},
+ * and {@link UdfTypes.StructType}.
+ */
+public interface UdfType {
+
+  enum TypeID {
+    PRIMITIVE,
+    LIST,
+    MAP,
+    STRUCT
+  }

Review Comment:
   Shouldn't this be in a more prominent place? This is basically a "kind" 
(i.e. a type of type) and applies to all types, not just anything UDF-specific.
   
   In other places, a "UDF type" usually splits into:
   * scalar (returns a single value, which may be a composite value)
   * aggregate (a user-defined aggregate function; distribution/state/combining 
parameters)
   * table (returns a table)



##########
api/src/main/java/org/apache/iceberg/udf/UdfType.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.udf;
+
+/**
+ * Represents a UDF data type as defined in the UDF spec. UDF types are based 
on Iceberg types but
+ * intentionally omit field IDs and element nullability. Concrete 
implementations live as static
+ * nested classes on {@link UdfTypes}: {@link UdfTypes.PrimitiveType} for 
primitive and
+ * semi-structured types, and the nested types {@link UdfTypes.ListType}, 
{@link UdfTypes.MapType},
+ * and {@link UdfTypes.StructType}.
+ */
+public interface UdfType {
+
+  enum TypeID {
+    PRIMITIVE,
+    LIST,
+    MAP,
+    STRUCT
+  }

Review Comment:
   A lot of this seems like what I would call "value types", a core feature of 
a type system, as opposed to anything UDF-related. 
   
   I suppose, by happenstance, UDF support may just be the first time this kind 
of metadata became important, rather than being its natural home. 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to