anoopj commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4568575615


##########
core/src/main/java/org/apache/iceberg/BaseDistributedDataScan.java:
##########
@@ -146,6 +147,17 @@ protected PlanningMode deletePlanningMode() {
   protected CloseableIterable<ScanTask> doPlanFiles() {
     Snapshot snapshot = snapshot();
 
+    if (snapshot.rootManifestLocation() != null) {

Review Comment:
   Thanks. This is much simpler and will incorporate it. I didn't know about 
the table capability. 



##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -64,6 +64,10 @@ protected TableScan newRefinedScan(Table table, Schema 
schema, TableScanContext
   public CloseableIterable<FileScanTask> doPlanFiles() {
     Snapshot snapshot = snapshot();
 
+    if (snapshot.rootManifestLocation() != null) {
+      return planV4RootManifest(snapshot);

Review Comment:
   agree. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to