anoopj commented on PR #18884: URL: https://github.com/apache/iceberg/pull/18884#issuecomment-6865914801
> This is a test plan I was able to come up with for the scan planning changes. I think it'd fit well in the existing scan suites gated on v4, with `commitRootManifestSnapshot` moved into `V4TestHelpers` so both core and Spark can use it. Some of these you already covered, so change needed (mentioned in each row). Let me know what you think! > @amogh-jahagirdar Thanks for writing the test plan. Per the feedback from Ryan, we will keep tests to minimal. The write path will add extensive tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
