sdaberdaku commented on code in PR #18936:
URL: https://github.com/apache/iceberg/pull/18936#discussion_r4570007651
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -183,11 +185,23 @@ private static OutputFile newPartitionStatsFile(
private static Collection<PartitionStatistics>
computeAndMergeStatsIncremental(
Table table, Snapshot snapshot, long lastSnapshotWithStats) {
PartitionMap<PartitionStatistics> statsMap =
PartitionMap.create(table.specs());
+ StructType partitionType = Partitioning.partitionType(table);
+ Map<Integer, StructProjection> specPartitions = Maps.newHashMap();
try (CloseableIterable<PartitionStatistics> oldStats =
table.newPartitionStatisticsScan().useSnapshot(lastSnapshotWithStats).scan()) {
- oldStats.forEach(
- partitionStats ->
- statsMap.put(partitionStats.specId(),
partitionStats.partition(), partitionStats));
Review Comment:
Confirmed, the test passes on top of #18784 without the
`PartitionStatsHandler` change. I dropped the fix, kept only the test and
rebased onto #18784. The PR is a draft until #18784 merges, then I'll rebase it
onto main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]